Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Auth controller tests for RHOAI #1499

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Update Auth controller tests for RHOAI #1499

merged 1 commit into from
Jan 15, 2025

Conversation

VaishnaviHire
Copy link
Member

(cherry picked from commit 3b18522)

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested a review from CFSNM January 14, 2025 18:47
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.88%. Comparing base (71f79e2) to head (c144e12).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1499   +/-   ##
=======================================
  Coverage   19.88%   19.88%           
=======================================
  Files         160      160           
  Lines       10818    10818           
=======================================
  Hits         2151     2151           
  Misses       8440     8440           
  Partials      227      227

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lburgazzoli
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 15, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ad20d38 into opendatahub-io:main Jan 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lburgazzoli lburgazzoli lburgazzoli approved these changes

@zdtsw zdtsw zdtsw approved these changes

@StevenTobin StevenTobin Awaiting requested review from StevenTobin

@CFSNM CFSNM Awaiting requested review from CFSNM

Assignees

@zdtsw zdtsw

@lburgazzoli lburgazzoli

Labels
approved lgtm
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VaishnaviHire @lburgazzoli @zdtsw